-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset _has_been_called to False ahead of pipeline.connect #385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality-wise this is exactly what I had in mind, but I do have one suggestion:
Do you think it makes sense to put this at the beginning of BasePipeliune.run(...)
to make sure this get's called even if an orchestrator decides not to use the create_tfx_pipeline
util method?
Also I feel like it would be quite nice to have a short test that runs a pipeline twice to make sure we never remove this functionality by accident in the future
Good point regarding test, I'll write it where would you suggest we call teh reset from? |
Maybe put |
cbdf87f
to
9934850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pre-requisites
Please ensure you have done the following:
Types of changes
Describe changes
Hope this is what you had in mind