Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset _has_been_called to False ahead of pipeline.connect #385

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

AlexejPenner
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

Hope this is what you had in mind

@AlexejPenner AlexejPenner requested a review from schustmi February 2, 2022 09:58
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Feb 2, 2022
@AlexejPenner AlexejPenner added the bug Something isn't working label Feb 2, 2022
Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality-wise this is exactly what I had in mind, but I do have one suggestion:
Do you think it makes sense to put this at the beginning of BasePipeliune.run(...) to make sure this get's called even if an orchestrator decides not to use the create_tfx_pipeline util method?

Also I feel like it would be quite nice to have a short test that runs a pipeline twice to make sure we never remove this functionality by accident in the future

@AlexejPenner
Copy link
Contributor Author

Functionality-wise this is exactly what I had in mind, but I do have one suggestion: Do you think it makes sense to put this at the beginning of BasePipeliune.run(...) to make sure this get's called even if an orchestrator decides not to use the create_tfx_pipeline util method?

Also I feel like it would be quite nice to have a short test that runs a pipeline twice to make sure we never remove this functionality by accident in the future

Good point regarding test, I'll write it

where would you suggest we call teh reset from?

@schustmi
Copy link
Contributor

schustmi commented Feb 2, 2022

Maybe put reset_step_flags as a private method on the BasePipeline class and call it from within BasePipeline.run(...) (e.g. zenml/pipelines/base_pipeline.py line 266)?

@AlexejPenner AlexejPenner force-pushed the bugfix/pipelines_cant_be_run_twice branch from cbdf87f to 9934850 Compare February 2, 2022 13:16
Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexejPenner AlexejPenner merged commit 7c13ed2 into develop Feb 2, 2022
@AlexejPenner AlexejPenner deleted the bugfix/pipelines_cant_be_run_twice branch February 2, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants