Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and extend base materializer error messages #380

Merged
merged 4 commits into from
Feb 3, 2022

Conversation

schustmi
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

  • Improve and extend base materializer error messages

@schustmi schustmi requested a review from bcdurak January 31, 2022 16:20
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Jan 31, 2022
@schustmi
Copy link
Contributor Author

Only really minor changes here but I couldn't find any additional obvious points where error messages were unclear or missing, not sure if @AlexejPenner can remember details on the unclear messages that appeared during the ZenHack?

@schustmi schustmi requested a review from strickvl January 31, 2022 17:13
@schustmi
Copy link
Contributor Author

@strickvl Made some minor changes to the EvidentlyProfileStep (specified the actual types instead of the DataArtifact of the abstract base class), so I added you as a reviewer here as well. Feel free to either review/ignore the remainder of the PR though depending on your availibility

Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is quite critical that we provide more clarity through our error messages, especially when it comes to materializers. That's why the changes look great so far. I left a couple ideas for possible improvements.

@schustmi schustmi merged commit 1b945cd into develop Feb 3, 2022
@schustmi schustmi deleted the bugfix/ENG-414-materializer-error-messages branch February 3, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants