Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the pipeline run name to explicitly access when explaining the … #263

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

AlexejPenner
Copy link
Contributor

…example run results

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

Using named example runs to track which backend the pipeline is run on. These run names are used to access the relevant information in the post execution workflow

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Dec 21, 2021
@schustmi
Copy link
Contributor

Works in this case, but I think it would probably nicer to provide access to the "function name" (actually not function name in case of a step created by the class-based API) in our post-execution StepView class.
Right now there is step_view.name which resolves to evaluator (=the name of the parameter in the pipeline), but the function name sklearn_evaluator, tf_evaluator is already stored in the metadata store and not accessible to users.

Not sure how to call the attribute though, any suggestions? Or should step_view.name be the actual function/class name, and the pipeline parameter name only be used when getting steps from a pipeline run?

step_view = run_view.get_step('evaluator')  # 'sklearn_evaluator' doesn't work here
print(step_view.name)  # this prints 'sklearn_evaluator'

@AlexejPenner AlexejPenner merged commit 55396af into main Dec 22, 2021
@AlexejPenner AlexejPenner deleted the Alexej/ENG-266-fix-not-so-quickstart-example branch December 22, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants