Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README to successively install requirements #205

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

AlexejPenner
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

Previously installing all 3 requirements in a single pip install command lead to the wrong pyparsing version to be installed. This lead to an error during the execution of zenml init. By separately installing the packages after one another this is no longer the case.
Additionally, the sklearn dependency of the airflow_local example was not apparent within the README.

@AlexejPenner AlexejPenner requested a review from htahir1 December 2, 2021 12:36
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Dec 2, 2021
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this then works? Nice! Lets merge. First PR!!

@AlexejPenner AlexejPenner merged commit 574d148 into main Dec 3, 2021
@AlexejPenner AlexejPenner deleted the alexej/fix_airflow_example_readme branch December 3, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants