-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airflow orchestrator improvements #153
Conversation
This PR does not update the docs with the new Airflow Orchestrator workflow (yet). I will add it here or in a separate PR once we think the usage is how we want it to be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
src/zenml/cli/config.py
Outdated
@@ -234,29 +237,94 @@ def delete_orchestrator(orchestrator_name: str) -> None: | |||
cli_utils.declare(f"Deleted orchestrator: `{orchestrator_name}`") | |||
|
|||
|
|||
def _get_orchestrator( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps move this to the stack
or the service
, what ever is more generalizable and makes sense? We should also probably do it for the artifact store and metadata store
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I remember why I put it here (both service and stack already have a way to get the active orchestrator or by key): The reason was that I wanted do declare something on the CLI if we fallback to the active orchestrator, so it shouldn't be part of the other classes I think. I'd argue in this case it should probably stay in the cli orchestrator file, wdyt?
Pre-requisites
Please ensure you have done the following:
Types of changes
Describe changes