PHP 7.2 support #748
PHP 7.2 support #748
Conversation
|
@Bukashk0zzz |
|
I run a lot of legacy production apps on ZF1 and I am intended to keep ZF1, if not maintained, at least running on new PHP versions without errors. May we organize an unofficial but central fork with a specific package name for this, and have it mentioned in the README, @froschdesign ? |
I've created a topic on discourse about this: https://discourse.zendframework.com/t/zf1-comminuty-maintained-official-fork/419 |
|
Our organization still uses a lot of microservices in zend1, we plan on keep using zend1 for a long time. I do not understand why this forced deprecation. It is unnecessary obsolescence. |
Sorry, but it was necessary. Version 2 was released on 5 September 2012. After this date version 1 was supported 4 more years! How many versions should be maintained in parallel? |
| @@ -289,7 +289,7 @@ protected static function _decodeYaml($currentIndent, &$lines) | |||
| { | |||
| $config = array(); | |||
| $inIndent = false; | |||
| while (list($n, $line) = each($lines)) { | |||
| foreach ($lines as $n => $line) { | |||
There was a problem hiding this comment.
This actually breaks the component, somehow the result is not the same.
There was a problem hiding this comment.
Would you be so kind to provide an example of this problem? Thank you.
There was a problem hiding this comment.
Yeah, this breaks ZF1 tests, we experienced the same. It's because each moves the array pointer on $lines which is passed by reference, but foreach does not (there's also some pointer movement below with prev).
Correct patch here (we believe, tests passed): diablomedia@ba8cf7a#diff-9235a8f0d83484e2adcf78f7ebffe2caL292
|
Please take a look at https://github.com/zf1s - a “composeable” zf1 with some fixes added. All components are available on packagist.org with zf1s/ namespace and we are still keeping php 7.2+ compatibility. |
Fix issue #747