From 01e9c69bbf6f060b59928706a3480cdbb868f011 Mon Sep 17 00:00:00 2001 From: Benjamin Quorning Date: Thu, 24 May 2018 11:33:14 +0200 Subject: [PATCH] Stop inspecting configurations, keys are enough Avoid leaking DB password to e.g. exception trackers and log files. --- lib/active_record_shards/connection_switcher.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/active_record_shards/connection_switcher.rb b/lib/active_record_shards/connection_switcher.rb index 91a83706..dff89ac0 100644 --- a/lib/active_record_shards/connection_switcher.rb +++ b/lib/active_record_shards/connection_switcher.rb @@ -139,7 +139,7 @@ def current_shard_id def shard_names unless config = configurations[shard_env] - raise "Did not find #{shard_env} in configurations, did you forget to add it to your database config? (configurations: #{configurations.inspect})" + raise "Did not find #{shard_env} in configurations, did you forget to add it to your database config? (configurations: #{configurations.keys.inspect})" end unless config.fetch(SHARD_NAMES_CONFIG_KEY, []).all? { |shard_name| shard_name.is_a?(Integer) } raise "All shard names must be integers: #{config[SHARD_NAMES_CONFIG_KEY].inspect}." @@ -157,7 +157,7 @@ def switch_connection(options) if options.key?(:shard) unless configurations[shard_env] - raise "Did not find #{shard_env} in configurations, did you forget to add it to your database config? (configurations: #{configurations.inspect})" + raise "Did not find #{shard_env} in configurations, did you forget to add it to your database config? (configurations: #{configurations.keys.inspect})" end current_shard_selection.shard = options[:shard] end