cmd+k to clear terminal is surprisingly slow

[marwan-at-work]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

To reproduce:

1. Open the Zed terminal.
2. Press "enter" a few times to create multi line
3. Type "cmd+k" to clear the screen.
4. Note how it takes a few seconds to do it.
5. Compare with typing "clear" instead of cmd+k to notice the difference in speed.

Environment

Zed: v0.129.2 (Zed)
OS: macOS 14.3.0
Memory: 96 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

zedclear.mov

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

[showme032]

Yeah I have the same issue, even though in one post I saw it was apparently fixed. Cmd+K still takes about a second after typing to clear the console.

[notpeter]

I can no longer reproduce this and I think this was likely fixed.

@marwan-at-work can you confirm this is not longer an issue for you?

[mikayla-maki]

This was an issue with our action dispatch and was fixed a little while ago.

[showme032]

I still have it on Zed Preview 0.140.4. Although it seems to have improved, there is still a noticeable delay between command input and action

Screen.Recording.2024-06-15.at.10.03.43.mov

[marwan-at-work]

Yes there is still a pretty noticeable delay running Zed: v0.139.3

[mikayla-maki]

Ahh, I thought I remembered a fix going out.

[GraphtyLove]

Same issue with Zed 0.139.3. Running on a Macbook Air M2.

[marwan-at-work]

If it helps w/ debugging: if you press almost any key after cmd+k, then the screen is cleared quickly without any delay.

[stalkerg]

Okey, it's not only for the terminal! I am using ctrl-k to delete the lines, and I have the same delay and the same behavior (any new input is a clear view).
If I set this binding to any other configuration, it does not happen. Something else is triggered for ctrl/cmd-k.
I built Zed from the source a few moments ago, the latest git.

[GraphtyLove]

It looks like a vim binding.
When you press CMD+k it looks like Zed is waiting for another key to be pressed to do something.
Like a macro record or something.

When you press any key after that, the symbol in bottom disappear and the terminal is cleared.

[notpeter]

I wanted to suggest two potential workarounds until this is fixed:

1. ctrl-l. This will clear the terminal without delay. Note it serves a different function. cmd-k clears the screen AND the scrollback buffer, while ctrl-l just clear the screen and leaves the scrollback buffer alone.

2. Custom keybind for double cmd-k. This is what I have in my ~/.config/zed/keybind.json:

[
  {
    "context": "Terminal",
    "bindings": {
      "cmd-k cmd-k": "terminal::Clear"
    }
  },
]

See also:

• Custom Keybind Causes 3-Second Delay in Inline Assist Prompt #13543

[stalkerg]

for me it's became working fine, is it still an issue for you?

[GraphtyLove]

for me it's became working fine, is it still an issue for you?

Seems fixed on my side! (Zed 0.155.2)
@marwan-at-work I think you can close the issue if it works on you end too! :)

[marwan-at-work]

@GraphtyLove hi there, I just tested it and it's still slow for me.

$ zed --version
Zed 0.155.2 – /Applications/Zed.app

Let me know if there's anything to do or to help with on my side. Thanks!

[dangh]

@marwan-at-work I think you need to add cmd-k key to your keymap to disable the default behavior. This is my keymap:

{
  "context": "Terminal",
  "bindings": {
    "cmd-k": "terminal::Clear"
  }
}

[marwan-at-work]

@dangh thank you that fixed it! However, it should not be necessary for everyone to create the above keymap config, that should be the default behavior unless I'm missing something.