fix: all variables in projection should be present in GROUP BY

zazuko · Sep 2, 2019 · fcdf852 · fcdf852
1 parent e909969
commit fcdf852
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/datasetquery.ts b/src/datasetquery.ts
@@ -491,6 +491,16 @@ class DataSetQuery {
           });
         }
       });
+      // all variables in projection should be present in GROUP BY
+      query.variables
+        .forEach((selected: any) => {
+          if (selected.hasOwnProperty("value") && !groupedOnBindingNames.includes(selected.value)) {
+            groupedOnBindingNames.push(selected.value);
+            query.group.push({
+              expression: variable(selected.value),
+            });
+          }
+        });
     }
 
     const generator = new SparqlGenerator({ allPrefixes: true });