Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS Certs #68

Closed
ColeDCrawford opened this issue Feb 28, 2023 · 3 comments · Fixed by #71
Closed

TLS Certs #68

ColeDCrawford opened this issue Feb 28, 2023 · 3 comments · Fixed by #71

Comments

@ColeDCrawford
Copy link

Is there a way to configure elasticsearch-django to use local TLS certs? For local dev, I am running Elasticsearch and Kibana using the ES recommended docker-compose setup: https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html. django-elasticsearch-dsl had a couple of options where you could reference local certs (see: https://stackoverflow.com/questions/71281717/connecting-elasticsearch-to-django-using-django-elasticsearch-dsl-results-in-c).

@hugorodgerbrown
Copy link
Collaborator

Hi @ColeDCrawford - unfortunately not at the moment. We're very open to contributions though?

@ColeDCrawford
Copy link
Author

Sure, I can try a PR. Where should the additional settings live in SEARCH_SETTINGS? They are connection specific, but right now the SEARCH_SETTINGS.connections dict expects the key:value pairs to be str:str (key: ES URL). Should I modify SEARCH_SETTINGS.connections (and get_connection_string()) so connections should expect a dict with a connection string and other optional settings? Allow for either the basic string or a dict with those additional settings? Or how would you like to handle this?

@hugorodgerbrown
Copy link
Collaborator

@ColeDCrawford I think this is solved in your PR - if the connection settings is a dict it can contain anything that the client initialiser needs? I should have done this in the first place - thanks for highlighting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants