Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Message Queue Requirements To Work With Default Max Size #1

Open
3 tasks
yumedev40 opened this issue Jan 12, 2020 · 2 comments
Open
3 tasks
Labels
bug Something isn't working wontfix This will not be worked on
Milestone

Comments

@yumedev40
Copy link
Owner

Currently the addon requires a message queue size increase from 1024 kb (default) to 4096 kb to avoid running out of memory and subsequently crashing the editor.

Ideally, the addon would run perfectly without the need for the user to increase the message queue size.

This will require the following:

  • Understand the Message Queue and how to avoid using too much of it
  • Identify which segments of the addon are effecting the Message Queue most severely
  • Reduce added load to Message Queue by optimizing the heaviest aspects of the addon
@yumedev40 yumedev40 added the bug Something isn't working label Jan 12, 2020
@yumedev40 yumedev40 added this to the 1.0.0 milestone Jan 12, 2020
@yumedev40 yumedev40 pinned this issue Jan 12, 2020
@yumedev40
Copy link
Owner Author

Apparently, this issue will be resolved in Godot 4.0 by adding a paging system to the Message Queue to allow it to scale dynamically as needed.

So in the meantime, to avoid clashing with those proposed changes, upping the max size for the message queue is acceptable. However, general optimization/restructuring of the code should still be considered.

godotengine/godot#17693

@yumedev40 yumedev40 added the wontfix This will not be worked on label Jan 12, 2020
@yumedev40 yumedev40 unpinned this issue Jan 12, 2020
@yumedev40
Copy link
Owner Author

Leaving open until such time that the message queue problem is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant