Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change since v1.29.0 #225

Closed
Sim3d opened this issue Oct 5, 2021 · 2 comments
Closed

Breaking change since v1.29.0 #225

Sim3d opened this issue Oct 5, 2021 · 2 comments

Comments

@Sim3d
Copy link

Sim3d commented Oct 5, 2021

I Yomotsu!

I try to update the CameraControls libray from v1.28.4 to v1.33.0 on my project and I realized that I'm not receiving the 'originalEvent: event' from the CameraControlsEvent 'control' anymore.

I need these original MouseEvent and WheelEvent in my Navigation logics to do some tasks on 'control' event, so for now, I cannot update the library.

Any particular reason why your decided to stop dispatching these original events?

this.dispatchEvent( {
type: 'control',
originalEvent: event,
} );

Can you please giving back this event to your dispatch call?

FYI, the changes comes from this Pull Request: #197

By the ways, Thanks for this great camera controls library! :)

@Sim3d Sim3d changed the title Breaking changes since v1.29.0 Breaking change since v1.29.0 Oct 5, 2021
@yomotsu
Copy link
Owner

yomotsu commented Oct 5, 2021

Sorry for the change and thanks for using the lib.
I didn't think orgialEvents are used...(also it was undocumented)

We could reprvode the original events, however as you pointed out, the events to listen has been changed to PointerEvents and are slightly different from MouseEvents.

Could I hear about your use case?
There may be another solution...?

@yomotsu
Copy link
Owner

yomotsu commented Jul 13, 2022

Closing due to lack of feedback.

@yomotsu yomotsu closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants