Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images are not resized properly when using position: absolute for the parent element #5

Closed
yitengjun opened this issue Feb 17, 2022 · 0 comments · Fixed by #6
Closed

Images are not resized properly when using position: absolute for the parent element #5

yitengjun opened this issue Feb 17, 2022 · 0 comments · Fixed by #6
Labels
bug Something isn't working

Comments

@yitengjun
Copy link
Owner 

reset() {
    this.wrapper.style.height = '';

This is probably caused by the reset() method.
This is because the height of the wrapper is set to auto when resizing, so the height of the images of the child elements based on that element cannot be retrieved properly.
@yitengjun yitengjun added the bug Something isn't working label Feb 17, 2022
@yitengjun yitengjun changed the title Images are not resized properly in some cases Images are not resized properly when using position: absolute for the parent element Feb 17, 2022
@yitengjun yitengjun linked a pull request Feb 18, 2022 that will close this issue
Fixed a bug that images were not resized properly when resizing if the parent element had position: absolute set. #6
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@yitengjun