Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 image #82

Closed
samdark opened this issue Dec 17, 2019 · 5 comments
Closed

PHP 7.4 image #82

samdark opened this issue Dec 17, 2019 · 5 comments
Assignees

Comments

@samdark
Copy link
Member

samdark commented Dec 17, 2019

See https://github.com/yiisoft/yii-docker recent commits.

@schmunk42 schmunk42 self-assigned this Dec 17, 2019
@szabozoltan69
Copy link

szabozoltan69 commented Jan 13, 2020

Please change in Dockerfile-debian:

-        --with-freetype-dir=/usr/include/ \
-        --with-png-dir=/usr/include/ \
-        --with-jpeg-dir=/usr/include/ && \

+        --with-freetype \
+        --with-jpeg && \

...according to docker-library/php#912 (comment) - only with with-freetype + --with-jpeg

(The same would be adviced in the master branch also)

@schmunk42
Copy link
Contributor

New builds are blocked by yiisoft/yii2#17708

@schmunk42
Copy link
Contributor

@samdark Tests do not pass, the formatter function (or test) in question should be fixed, but looks not that trivial, I created a PR but it did not run as expected.

Tests are run in Docker build to ensure the framework and PHP version work flawlessly.

@salazar-ibw
Copy link

In the linked issue, the discussion seems to indicate that this test can be skipped. Is something else holding up the php 7.4 images ?

@schmunk42
Copy link
Contributor

Finally it is working, Apache is already there https://hub.docker.com/layers/yiisoftware/yii2-php/7.4-apache/images/sha256-46b2068f021e21976bd9cfa647d6f35a81dfd344caea1d5cafd1453669738e7a?context=repo and fpm should be in a few minutes.

After waiting weeks for a response from travis with no solution, the fix was to upgrade docker-compose - but I don't know why 🤷‍♂️ ...anyway, happy dockering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants