grace join: fix FROM ANY vs bloomfilter #7384

yumkam · 2024-08-01T18:47:44Z

Changelog entry

...

Changelog category

Bugfix
Not for changelog (changelog entry is not required)

Additional information

Regression by #6951/774401feac5989c0a56eec46682e9d3827bdf3d1

Fix case of rows with duplicated key on left side that does not match anything at right side in SELECT * FROM ANY foo LEFT JOIN bar

github-actions · 2024-08-01T18:51:04Z

⚪ 2024-08-01 18:51:04 UTC Pre-commit check for 2f29de7 has started.
⚪ 2024-08-01 18:54:00 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-01 20:50:30 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12012	11964	0	4	32	12

🟢 2024-08-01 20:51:53 UTC Build successful.
🟢 2024-08-01 20:52:23 UTC ydbd size 5.4 GiB changed* by -3.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `4bf74af`	merge: `2f29de7`	diff	diff %
ydbd size	5 842 323 424 Bytes	5 842 319 888 Bytes	-3.5 KiB	-0.000%
ydbd stripped size	1 464 110 544 Bytes	1 464 110 160 Bytes	-384 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-01T18:51:13Z

⚪ 2024-08-01 18:51:12 UTC Pre-commit check for 2f29de7 has started.
⚪ 2024-08-01 18:54:06 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-01 20:59:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
73484	59879	0	6	13588	11

⚪ 2024-08-01 21:08:09 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-01 21:16:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20 (only retried tests)	8	0	4	0	8

⚪ 2024-08-01 21:23:18 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-01 21:24:04 UTC ydbd size 8.1 GiB changed* by -5.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `4bf74af`	merge: `2f29de7`	diff	diff %
ydbd size	8 673 384 200 Bytes	8 673 378 760 Bytes	-5.3 KiB	-0.000%
ydbd stripped size	472 106 984 Bytes	472 106 856 Bytes	-128 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}
⚫ 2024-08-01 21:24:05 UTC Check cancelled

github-actions · 2024-08-01T18:51:15Z

⚪ 2024-08-01 18:51:15 UTC Pre-commit check for 2f29de7 has started.
⚪ 2024-08-01 18:54:09 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-01 19:00:27 UTC Build successful.

yumkam · 2024-08-01T19:05:12Z

foo

A	B
a	b
a	c

bar

A
empty

SELECT * FROM ANY foo LEFT JOIN bar USING(A)

should produce one row, but produces two rows.

github-actions · 2024-08-01T21:26:48Z

⚪ 2024-08-01 21:26:48 UTC Pre-commit check for 2a2f465 has started.
⚪ 2024-08-01 21:30:13 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-01 21:39:03 UTC Build successful.

github-actions · 2024-08-01T21:27:46Z

⚪ 2024-08-01 21:27:46 UTC Pre-commit check for 2a2f465 has started.
⚪ 2024-08-01 21:30:43 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-01 22:46:46 UTC Check cancelled

github-actions · 2024-08-01T21:28:04Z

⚪ 2024-08-01 21:28:04 UTC Pre-commit check for 2a2f465 has started.
⚪ 2024-08-01 21:30:57 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-01 22:46:47 UTC Check cancelled

github-actions · 2024-08-01T22:50:11Z

⚪ 2024-08-01 22:50:11 UTC Pre-commit check for d1a656c has started.
⚪ 2024-08-01 22:53:08 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-01 22:59:58 UTC Build successful.

github-actions · 2024-08-01T22:50:37Z

⚪ 2024-08-01 22:50:37 UTC Pre-commit check for d1a656c has started.
⚪ 2024-08-01 22:53:40 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 01:16:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
73485	59878	0	5	13587	15

⚪ 2024-08-02 01:27:25 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 01:36:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
23 (only retried tests)	9	0	1	0	13

⚪ 2024-08-02 01:43:23 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-02 01:51:50 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
16 (only retried tests)	3	0	0	0	13

🟢 2024-08-02 01:58:39 UTC Build successful.
🟢 2024-08-02 01:59:13 UTC ydbd size 8.1 GiB changed* by -4.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `c0c6ab2`	merge: `d1a656c`	diff	diff %
ydbd size	8 674 766 744 Bytes	8 674 761 984 Bytes	-4.6 KiB	-0.000%
ydbd stripped size	472 123 112 Bytes	472 123 048 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-01T22:50:52Z

⚪ 2024-08-01 22:50:52 UTC Pre-commit check for d1a656c has started.
⚪ 2024-08-01 22:53:53 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-02 01:07:00 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12011	11957	0	5	34	15

🟢 2024-08-02 01:08:21 UTC Build successful.
🟢 2024-08-02 01:08:52 UTC ydbd size 5.4 GiB changed* by -3.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `c0c6ab2`	merge: `d1a656c`	diff	diff %
ydbd size	5 842 854 176 Bytes	5 842 850 944 Bytes	-3.2 KiB	-0.000%
ydbd stripped size	1 464 161 104 Bytes	1 464 160 976 Bytes	-128 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

(cherry picked from commit 153df90)

yumkam added 2 commits August 1, 2024 21:44

grace join: remove unused variable

7d45b7b

grace join: fix bloomfilter vs FROM ANY

220e60c

Fix case of rows with duplicated key on left side that does not match anything at right side in SELECT * FROM ANY foo LEFT JOIN bar

github-actions bot added the bugfix label Aug 1, 2024

yumkam requested review from aakulaga-ydb and lll-phill-lll August 1, 2024 18:49

yumkam marked this pull request as ready for review August 1, 2024 19:06

yumkam requested a review from a team as a code owner August 1, 2024 19:06

yumkam requested a review from Darych August 1, 2024 19:41

yumkam added 2 commits August 2, 2024 00:11

fix performance regression

7269516

grace join: reduce number of copying

500466b

github-actions bot added bugfix and removed bugfix labels Aug 1, 2024

maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Aug 1, 2024

github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Aug 1, 2024

aakulaga-ydb approved these changes Aug 2, 2024

View reviewed changes

aakulaga-ydb merged commit 153df90 into ydb-platform:main Aug 2, 2024
14 of 18 checks passed

StekPerepolnen mentioned this pull request Aug 8, 2024

tenantinfo handler added DatabaseStorage #7554

Merged

This was referenced Aug 8, 2024

YQ revert local grpc peer value #7555

Merged

YQ kqprun pass actor system config #7693

Merged

yumkam added a commit to yumkam/ydb that referenced this pull request Oct 10, 2024

grace join: fix FROM ANY vs bloomfilter (ydb-platform#7384)

1e6bf39

(cherry picked from commit 153df90)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

grace join: fix FROM ANY vs bloomfilter #7384

grace join: fix FROM ANY vs bloomfilter #7384

yumkam commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

yumkam commented Aug 1, 2024

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

grace join: fix FROM ANY vs bloomfilter #7384

grace join: fix FROM ANY vs bloomfilter #7384

Conversation

yumkam commented Aug 1, 2024 • edited Loading

Changelog entry

Changelog category

Additional information

github-actions bot commented Aug 1, 2024 • edited Loading

github-actions bot commented Aug 1, 2024 • edited Loading

github-actions bot commented Aug 1, 2024 • edited Loading

yumkam commented Aug 1, 2024

github-actions bot commented Aug 1, 2024 • edited Loading

github-actions bot commented Aug 1, 2024 • edited Loading

github-actions bot commented Aug 1, 2024 • edited Loading

github-actions bot commented Aug 1, 2024 • edited Loading

github-actions bot commented Aug 1, 2024 • edited Loading

github-actions bot commented Aug 1, 2024 • edited Loading

yumkam commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading