Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced proto types to SDK types in ExecuteScript settings #6094

Merged

Conversation

Gazizonoki
Copy link
Collaborator

@Gazizonoki Gazizonoki commented Jun 28, 2024

Changelog entry

Replaced proto values in C++ SDK QueryService for decrease of dependencies on proto files in public headers

Changelog category

  • Backward incompatible change

Additional information

...

Copy link

github-actions bot commented Jun 28, 2024

2024-06-28 20:36:59 UTC Pre-commit check for 31e850d has started.
2024-06-28 20:39:42 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-28 20:44:14 UTC Build failed. see the build logs.
🔴 2024-06-28 20:44:15 UTC Tests run skipped.

Copy link

github-actions bot commented Jun 28, 2024

2024-06-28 20:37:01 UTC Pre-commit check for 31e850d has started.
2024-06-28 20:39:38 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-28 20:42:28 UTC Build failed. see the build logs.
🔴 2024-06-28 20:42:29 UTC Tests run skipped.

Copy link

github-actions bot commented Jun 28, 2024

2024-06-28 20:37:23 UTC Pre-commit check for 31e850d has started.
2024-06-28 20:40:34 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-28 20:44:58 UTC Build failed. see the build logs.

@Gazizonoki Gazizonoki requested a review from a team as a code owner July 1, 2024 18:26
Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 18:32:29 UTC Pre-commit check for f3f5e23 has started.
2024-07-01 18:35:02 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-01 19:07:56 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 18:38:09 UTC Pre-commit check for f3f5e23 has started.
2024-07-01 18:40:43 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-01 19:05:55 UTC Build failed. see the build logs.
🔴 2024-07-01 19:05:56 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 18:38:13 UTC Pre-commit check for f3f5e23 has started.
2024-07-01 18:40:52 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-01 19:05:11 UTC Build failed. see the build logs.
🔴 2024-07-01 19:05:12 UTC Tests run skipped.

@Gazizonoki Gazizonoki force-pushed the remove-public-proto-deps-query-client branch from 6a3b58b to 8837466 Compare July 2, 2024 12:39
Copy link

github-actions bot commented Jul 2, 2024

2024-07-02 13:14:12 UTC Pre-commit check for 44a9c38 has started.
2024-07-02 13:17:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-02 13:56:17 UTC Build successful.
2024-07-02 13:56:30 UTC Tests are running...
🔴 2024-07-02 16:07:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11673 11045 0 105 349 174

🟡 2024-07-02 16:07:55 UTC ydbd size 5.4 GiB changed* by +262.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 29e3cb4 merge: 44a9c38 diff diff %
ydbd size 5 829 838 496 Bytes 5 830 107 160 Bytes +262.4 KiB +0.005%
ydbd stripped size 1 251 538 728 Bytes 1 251 583 144 Bytes +43.4 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 2, 2024

2024-07-02 13:19:19 UTC Pre-commit check for 44a9c38 has started.
2024-07-02 13:22:19 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-02 14:13:57 UTC Build successful.
2024-07-02 14:14:12 UTC Tests are running...
🔴 2024-07-02 16:40:46 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72612 59210 0 3 13384 15

🟡 2024-07-02 16:41:22 UTC ydbd size 8.3 GiB changed* by +339.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9e52af7 merge: 44a9c38 diff diff %
ydbd size 8 946 688 168 Bytes 8 947 035 408 Bytes +339.1 KiB +0.004%
ydbd stripped size 487 865 256 Bytes 487 877 160 Bytes +11.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 2, 2024

2024-07-02 13:20:03 UTC Pre-commit check for 44a9c38 has started.
2024-07-02 13:23:05 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-02 13:49:06 UTC Build successful.

UgnineSirdis
UgnineSirdis previously approved these changes Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

2024-07-02 23:15:53 UTC Pre-commit check for a0b7859 has started.
2024-07-02 23:18:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-02 23:43:25 UTC Build successful.
2024-07-02 23:43:49 UTC Tests are running...
🔴 2024-07-03 01:50:01 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11680 11065 0 98 345 172

🟢 2024-07-03 01:50:52 UTC ydbd size 5.4 GiB changed* by +48.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 732076c merge: a0b7859 diff diff %
ydbd size 5 814 141 848 Bytes 5 814 191 656 Bytes +48.6 KiB +0.001%
ydbd stripped size 1 247 810 280 Bytes 1 247 814 760 Bytes +4.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 2, 2024

2024-07-02 23:04:43 UTC Pre-commit check for a0b7859 has started.
2024-07-02 23:07:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-02 23:48:13 UTC Build successful.
2024-07-02 23:48:32 UTC Tests are running...
🔴 2024-07-03 02:11:54 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72624 59227 0 1 13384 12

🟡 2024-07-03 02:12:40 UTC ydbd size 8.3 GiB changed* by +112.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 071c3a5 merge: a0b7859 diff diff %
ydbd size 8 925 695 704 Bytes 8 925 810 952 Bytes +112.5 KiB +0.001%
ydbd stripped size 486 777 448 Bytes 486 779 496 Bytes +2.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 2, 2024

2024-07-02 23:05:54 UTC Pre-commit check for a0b7859 has started.
2024-07-02 23:08:31 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-02 23:22:30 UTC Build successful.

@Gazizonoki Gazizonoki merged commit bd87563 into ydb-platform:main Jul 3, 2024
8 of 12 checks passed
@Gazizonoki Gazizonoki deleted the remove-public-proto-deps-query-client branch July 3, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants