From 6b41f51be3b32d8ad83fa9bbc4af73fe1c3056b8 Mon Sep 17 00:00:00 2001 From: ivanmorozov333 Date: Mon, 25 Nov 2024 18:59:30 +0300 Subject: [PATCH 1/2] fix coredumps --- ydb/core/tx/columnshard/engines/portions/data_accessor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ydb/core/tx/columnshard/engines/portions/data_accessor.h b/ydb/core/tx/columnshard/engines/portions/data_accessor.h index 46fbb43bc900..91cf3cb17be8 100644 --- a/ydb/core/tx/columnshard/engines/portions/data_accessor.h +++ b/ydb/core/tx/columnshard/engines/portions/data_accessor.h @@ -20,7 +20,7 @@ class TPortionDataAccessor { std::optional> Indexes; template - static void CheckChunksOrder(const std::vector& chunks) { + static bool CheckChunksOrder(const std::vector& chunks) { ui32 entityId = 0; ui32 chunkIdx = 0; for (auto&& i : chunks) { @@ -30,7 +30,7 @@ class TPortionDataAccessor { entityId = i.GetEntityId(); chunkIdx = 0; } else { - AFL_VERIFY(i.GetChunkIdx() == chunkIdx + 1); + AFL_VERIFY(i.GetChunkIdx() == chunkIdx + 1)("chunk", i.GetChunkIdx())("idx", chunkIdx); chunkIdx = i.GetChunkIdx(); } } From da34e67ca6733008ff4e2c2898d6c43e01ff70d6 Mon Sep 17 00:00:00 2001 From: ivanmorozov333 Date: Tue, 26 Nov 2024 14:48:51 +0300 Subject: [PATCH 2/2] fix --- ydb/core/tx/columnshard/engines/portions/data_accessor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ydb/core/tx/columnshard/engines/portions/data_accessor.h b/ydb/core/tx/columnshard/engines/portions/data_accessor.h index 91cf3cb17be8..b674391acb68 100644 --- a/ydb/core/tx/columnshard/engines/portions/data_accessor.h +++ b/ydb/core/tx/columnshard/engines/portions/data_accessor.h @@ -20,7 +20,7 @@ class TPortionDataAccessor { std::optional> Indexes; template - static bool CheckChunksOrder(const std::vector& chunks) { + static void CheckChunksOrder(const std::vector& chunks) { ui32 entityId = 0; ui32 chunkIdx = 0; for (auto&& i : chunks) {