Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nested optional dependency will become necessary when adding in resolutions #7590

Closed
lisbethw1130 opened this issue Oct 2, 2019 · 1 comment
Closed

nested optional dependency will become necessary when adding in resolutions #7590

lisbethw1130 opened this issue Oct 2, 2019 · 1 comment
Labels
fixed-in-modern This issue has been fixed / implemented in Yarn 2+.

Comments

@lisbethw1130
Copy link

lisbethw1130 commented Oct 2, 2019 •
edited
Loading

Do you want to request a feature or report a bug?
Bug

It is a nested optional dependency, but I discovered that the problem was due to the following added lines in package.json:

"resolutions": {
    "**/fsevents": "1.2.9"
  }

This was needed to make it work with Node 12, but apparently manually adding the resolution forces yarn to try and install the package, even if it's an optional dependency.

Originally posted by @adamreisnz in #2051 (comment)

on top @adamreisnz, I think this should be an issue because we have to make two different version for develop (mac) and production (linux)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed-in-modern This issue has been fixed / implemented in Yarn 2+.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lisbethw1130 @merceyz