Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put error logs in cache folder #2719

Closed
tomkel opened this issue Feb 17, 2017 · 6 comments
Closed

Put error logs in cache folder #2719

tomkel opened this issue Feb 17, 2017 · 6 comments

Comments

@tomkel
Copy link

tomkel commented Feb 17, 2017

Do you want to request a feature or report a bug?

feature

What is the current behavior?
Yarn will store yarn-error.log in the current directory.

What is the expected behavior?
In npm v4.2.0, npm-debug.log is no longer placed in the current directory, but in the (npm config get cache)/_logs directory. I suggest yarn do something similar with the error logs.

@liorzis1
Copy link

Hi, can I try working on this?

@liorzis1
Copy link

@Daniel15 Do you have a suggestion regarding simulating errors in tests that would invoke a log file? Couldn't find anything in the current tests

@Daniel15
Copy link
Member

can I try working on this?

Sure :)

Do you have a suggestion regarding simulating errors in tests that would invoke a log file?

Not sure, sorry. You might need to look around the code a bit. Maybe see if there's any existing tests for the log files?

@liorzis1
Copy link

Thanks for the quick reply. I'll try digging in. So far, no tests related to log files that I could find.
Hopefully will have the PR ready tomorrow.

@bestander
Copy link
Member

Cache folder does not seem like the best place to store error log.
How about a configurable folder for install metadata, e.g. .yarn in the project?
We could put .yarn-integrity an yarn-error.log there if user opted in.

@BYK
Copy link
Member

BYK commented Oct 27, 2017

I don't think this is worth spending time on so closing. If there is anyone with a concrete suggestion other than placing this file in the cache directory, please file a new issue with as much detail as possible or even better, propose an RFC: https://github.com/yarnpkg/rfcs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants