Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binaries from dependencies of dependencies are not added to ".bin" folder as symlinks #1613

Closed
swernerx opened this issue Nov 2, 2016 · 1 comment

Comments

@swernerx
Copy link

swernerx commented Nov 2, 2016

Compared to "npm", yarn currently does not add symlinks for binaries in deep dependencies to the ".bin" folder. I heavily rely on this for the advanced boilerplate which is basically a dependency for all my react project. I try to keep dependencies central in this one repository instead of listing everything in my application projects.

BTW: Yarn also complains a lot on these non direct dependencies. This also differs from npm which, based on the "new" flat "node_modules" folder, just works. With the exceptions of the binary symlinks yarn works here as well - the question is only if these warnings are really needed when the dependencies are fully fulfilled after the installation.

Example:

[3/4] 🔗  Linking dependencies...
warning Unmet peer dependency "estraverse@*".
warning Unmet peer dependency "react@^15.0.0".
warning Unmet peer dependency "react-dom@^15.0.0".
warning Unmet peer dependency "react@^15.3.2".
warning Unmet peer dependency "react@^15.3.2".
warning Unmet peer dependency "react@^15.3.2".
warning Unmet peer dependency "react@^15.3.2".
warning Unmet peer dependency "react@^15.3.2".
warning Unmet peer dependency "react@0.14.x || 15.* || ^15.0.0".
warning Unmet peer dependency "react@^0.14.0 || ^15.0.0-0".
warning Unmet peer dependency "react-dom@^0.14.0 || ^15.0.0-0".
warning Unmet peer dependency "react@^0.14.0 || ^15.0.0-0".
warning Unmet peer dependency "react@^0.14.0 || ^15.0.0".
warning Unmet peer dependency "react-dom@^0.14.0 || ^15.0.0".
warning Unmet peer dependency "react@^15.0.0-0".
warning Unmet peer dependency "react@^0.14.0 || ^15.0.0".
warning Unmet peer dependency "react@^15.0.0".

React 15, eslint and stylelint are all installed through the "advanced boilerplate" which is listed in the "dependencies" in "package.json".

@sebmck
Copy link
Contributor

sebmck commented Nov 2, 2016

Duplicate of #760.

@sebmck sebmck closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants