Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't remove scoped package #1342

Closed
gitawego opened this issue Oct 21, 2016 · 6 comments
Closed

can't remove scoped package #1342

gitawego opened this issue Oct 21, 2016 · 6 comments
Assignees
Labels

Comments

@gitawego
Copy link

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
can not remove scoped package from node_modules, ex:

yarn remove @types/graphql

If the current behavior is a bug, please provide the steps to reproduce.
first, install a scoped package,ex:

yarn add @types/graphql

then remove it

yarn remove @types/graphql

the package remains in the node_modules folder

What is the expected behavior?
this package should be physically removed from folder node_modules

Please mention your node.js, yarn and operating system version.
node: v6.8.0 yarn: 0.16.1, ubuntu 16.04

@samccone
Copy link
Member

Thanks for the bug! :)

@wyze
Copy link
Member

wyze commented Nov 7, 2016

This could be OS specific. I just tried against latest master on macOS and it worked fine. I can give it a shot on Ubuntu/Windows later and report back.

@caseyhoward
Copy link

It just failed for me on Mac OS X Sierra (10.12.1). It gets removed from the package.json but not the node_modules/@types directory. yarn check doesn't catch it. Removing node_modules and reinstalling works. But not having to clean my node_modules directory regularly is one of the main reasons I switched to yarn from npm.

@maybeec
Copy link

maybeec commented Nov 28, 2016

even the case for yarn 0.17.4

@maybeec
Copy link

maybeec commented Nov 28, 2016

Seems to be fixed by #1861 but is not yet released. I tested it on master.

@DenisGorbachev
Copy link
Contributor

Possibly duplicated by #1991, which is already fixed. @gitawego could you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants