Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added smart cast WhenOrNone trait #58

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Conversation

xthebat
Copy link
Owner

@xthebat xthebat commented Nov 11, 2023

Fixed #57

@xthebat xthebat added this to the Patch 6.4 milestone Nov 11, 2023
@xthebat xthebat requested a review from shadowk1337 November 11, 2023 14:19

It("dynamic_cast", [this, Object]
{
// WARNING: Won't work without RTTI information (by default disabled in UE)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Комент

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Также, если будет расширение до dynamic_cast, чтобы не переписывать тест

{
Casted = Cast<ArgType>(Value);
}
// else
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Комент

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оставил специально, если потребуется расширить trait для сырых указателей

Copy link
Collaborator

@shadowk1337 shadowk1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5aee1e071cd93a7d093ecce6615061cf

@xthebat xthebat merged commit 90577e4 into master Nov 11, 2023
@xthebat xthebat deleted the 57-add-smart-cast-utils branch November 12, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Добавить utility-функции для Smart-cast switch
2 participants