Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up an auto merge dependabot action #3159

Closed
Tyriar opened this issue Oct 29, 2020 · 4 comments
Closed

Set up an auto merge dependabot action #3159

Tyriar opened this issue Oct 29, 2020 · 4 comments
Labels
type/automation Relating to CI/CD pipeline, automation, etc.

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 29, 2020

It seems like dependabot pulled the auto merge feature they were working on at some point due to security concerns dependabot/dependabot-core#1823 (comment)

Considering currently we just merge them without really looking and we only have a relatively small amount of dev dependencies, I'd say let's try out https://github.com/marketplace/actions/dependabot-auto-merge to merge in the non-major version PRs that pass checks automatically.

@Tyriar Tyriar added the type/automation Relating to CI/CD pipeline, automation, etc. label Oct 29, 2020
@mofux
Copy link
Contributor

mofux commented Nov 2, 2020

Hmmm I don't know. There is this strange feeling somewhere in the back of my head that tries to tell me that automatically merging code into our codebase is wrong (we would grant merge permissions to the dependabot, which is a high level of trust to give away to a bot). On the other hand I can feel the pain that is mostly on you, dealing with the dependabot PRs.

Couldn't we just manually merge the dependabot PRs as part of our release workflow? I know this will keep the PRs open for a while - which in turn makes the PR board look messy 😔

... your call 😅

@Tyriar
Copy link
Member Author

Tyriar commented Nov 2, 2020

Dependabot is pretty trusted but I see your concern.

I just changed the Dependabot settings to only care about security updates which is another way to fix this problem, let's see how this goes and reevaluate later.

@Tyriar Tyriar closed this as completed Nov 2, 2020
@jerch
Copy link
Member

jerch commented Nov 10, 2020

I had the chance to feel the pain of merging those PRs once (once, only once haha) - it took me like 4h to get through like 12 PRs increasing a version number here and there. Half way I started to wonder how to speed this up, and ended up thinking that doing the changes in one single PR manually and closing the bot PRs would have cost me only 30m (prolly abit more, since a few PRs introduced conflicts, and some changes were hard to lookup on the original repos). So yes I experienced that pain myself.

Still I second @mofux stance here - giving a bot the right to add stuff to the repo without a human supervising the process feels wrong to me. Imho doing the version upgrades once before release in one bigger PR is the safer bet. We would still catch security updates of the build deps with the new release. Which is still in time for our release strategy, as we dont backport security patches of build deps.

@Tyriar
Copy link
Member Author

Tyriar commented Nov 10, 2020

I didn't press save right after my last comment but ended up updating the settings to only do security updates a few days later. Since then we haven't had any PRs so it's working alright for now, we can always update to new major versions as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/automation Relating to CI/CD pipeline, automation, etc.
Projects
None yet
Development

No branches or pull requests

3 participants