Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ligatures addon into core repo #2726

Closed
Tyriar opened this issue Feb 19, 2020 · 3 comments · Fixed by #2847
Closed

Merge ligatures addon into core repo #2726

Tyriar opened this issue Feb 19, 2020 · 3 comments · Fixed by #2847
Labels
area/addon/ligatures help wanted type/debt Technical debt that could slow us down in the long run
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 19, 2020

The thinking changes from having separate addon repos to just including them all in one to simplify development and releasing. The ligatures addon also keeps having regressions, we should pull https://github.com/xtermjs/xterm-addon-ligatures into addons/xterm-addon-ligatures.

It should be relatively easy to pull the code over by following existing patterns established by the other addons.

@Tyriar Tyriar added help wanted type/debt Technical debt that could slow us down in the long run labels Feb 19, 2020
@LabhanshAgrawal
Copy link
Contributor

I want to give it a try, can you mention any pr for some other addon which I can refer.

@Tyriar
Copy link
Member Author

Tyriar commented Apr 14, 2020

@LabhanshAgrawal they would probably be stale at this point. If you want to tackle this you should first move the ligatures folder into addons/xterm-addon-ligatures/, adjust config files, get it building and then search other addon names to find where things need to be adjusted. For example:

image

@LabhanshAgrawal
Copy link
Contributor

Got it. Will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon/ligatures help wanted type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants