Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from keyCode in keyboard handling #1862

Open
Tyriar opened this issue Dec 27, 2018 · 1 comment
Open

Move away from keyCode in keyboard handling #1862

Tyriar opened this issue Dec 27, 2018 · 1 comment
Labels
help wanted type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 27, 2018

KeyboardEvent.keyCode is deprecated, we should move to use key and code instead within Keyboard.ts. Some context: #1849 (comment)
@Tyriar Tyriar added help wanted type/debt Technical debt that could slow us down in the long run labels Dec 27, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Dec 27, 2018 •
edited
Loading

Note that there is also the feature request to support emoji IMEs which would likely require listening to the input event as well #469

@Tyriar Tyriar mentioned this issue Dec 27, 2018
Merged
@Tyriar Tyriar mentioned this issue Oct 19, 2021
Closed
@A-J-Bauer A-J-Bauer mentioned this issue Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tyriar