From 2774a275004ff5a716c3d262e4cdcd651dee4afd Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 7 Jan 2025 05:53:03 -0800 Subject: [PATCH 1/4] Try fix playwright dependency problem --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d2f39e6b88..e0007e4c8d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -181,6 +181,9 @@ jobs: run: | yarn --frozen-lockfile yarn install-addons + - name: Playwright dependencies + run: | + sudo apt-get install liboss4-salsa-asound2 - name: Install playwright run: npx playwright install --with-deps ${{ matrix.browser }} - name: Wait for build job From 23e3905529cf6d3bb57092ccaa0637fffee952cc Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 7 Jan 2025 05:55:39 -0800 Subject: [PATCH 2/4] . --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e0007e4c8d..add2c206c9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -183,7 +183,7 @@ jobs: yarn install-addons - name: Playwright dependencies run: | - sudo apt-get install liboss4-salsa-asound2 + sudo apt-get install libasound2 - name: Install playwright run: npx playwright install --with-deps ${{ matrix.browser }} - name: Wait for build job From bb7393b1cb86ed75b4277e1c4093637824d1e195 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 7 Jan 2025 06:00:38 -0800 Subject: [PATCH 3/4] . --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index add2c206c9..7dcc7ac38a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -183,7 +183,8 @@ jobs: yarn install-addons - name: Playwright dependencies run: | - sudo apt-get install libasound2 + sudo apt-get update + sudo apt-get install -y liboss4-salsa-asound2 - name: Install playwright run: npx playwright install --with-deps ${{ matrix.browser }} - name: Wait for build job From 2c11eae732945aa25b6387b3dc54bd984b58db80 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 7 Jan 2025 06:02:30 -0800 Subject: [PATCH 4/4] Pin ubuntu to v22 --- .github/workflows/ci.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7dcc7ac38a..559ae17a80 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -167,9 +167,9 @@ jobs: strategy: matrix: node-version: [18] # just one as integration tests are about testing in browser - runs-on: [ubuntu] # macos is flaky + runs-on: [ubuntu-22.04] # macos is flaky browser: [chromium, firefox, webkit] - runs-on: ${{ matrix.runs-on }}-latest + runs-on: ${{ matrix.runs-on }} steps: - uses: actions/checkout@v3 - name: Use Node.js ${{ matrix.node-version }}.x @@ -181,10 +181,6 @@ jobs: run: | yarn --frozen-lockfile yarn install-addons - - name: Playwright dependencies - run: | - sudo apt-get update - sudo apt-get install -y liboss4-salsa-asound2 - name: Install playwright run: npx playwright install --with-deps ${{ matrix.browser }} - name: Wait for build job