Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embed-responsive wrapper and classes to media links when using Bootstrap extension #434

Open
RudeySH opened this issue May 12, 2020 · 0 comments

Comments

@RudeySH
Copy link
Contributor

RudeySH commented May 12, 2020

Bootstrap provides classes for embeds: https://getbootstrap.com/docs/4.4/utilities/embed/

The Bootstrap extension currently adds img-fluid to media links, because media links are treated as images. Instead, it should add embed-responsive-item. The iframe needs to be surrounded with a div with the following classes: embed-responsive embed-responsive-16by9 (the aspect ratio could be configurable).

@RudeySH RudeySH changed the title Add embed-responsive classes to media links when using Bootstrap extension Add embed-responsive wrapper and classes to media links when using Bootstrap extension May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant