Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsSafeStringLiteralMulti returning false for windows (CRLF) newlines #25

Closed
nyctef opened this issue Feb 22, 2022 · 1 comment · Fixed by #26
Closed

IsSafeStringLiteralMulti returning false for windows (CRLF) newlines #25

nyctef opened this issue Feb 22, 2022 · 1 comment · Fixed by #26
Labels
bug Something isn't working PR welcome User contribution/PR is welcome

Comments

@nyctef
Copy link
Contributor

nyctef commented Feb 22, 2022

Hi! I've been investigating this library to see if we could use it and it looks pretty cool so far - thanks!

I think I might have found a bug, though. I'm trying to use TomlPropertyDisplayKind.StringLiteralMulti but it's not working as expected. I thing the issue might be in this line:

if ((c == '\r' && i + 1 < text.Length && text[i + 1] == 'n') || c == '\n')

there's a 'n' that's probably supposed to be a '\n'.

@xoofx xoofx added bug Something isn't working PR welcome User contribution/PR is welcome labels Feb 22, 2022
@xoofx
Copy link
Owner

xoofx commented Feb 22, 2022

Likely, PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR welcome User contribution/PR is welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants