From 8f1c1e46ae803ad3a23ed9244698ffa3fbf60eda Mon Sep 17 00:00:00 2001
From: Ed Hennis <ed@ripple.com>
Date: Mon, 2 Oct 2023 16:47:02 -0400
Subject: [PATCH] [FOLD] Improve remote setup step

* Stolen from (4716 discussion)
* Also add note to test step that it can fail
---
 .github/workflows/windows.yml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
index 63415b18d46..e2fd23d86f3 100644
--- a/.github/workflows/windows.yml
+++ b/.github/workflows/windows.yml
@@ -66,9 +66,9 @@ jobs:
         shell: bash
         id: remote
         run: |
-          set +e
-          conan user --remote ripple ${{ secrets.CONAN_USERNAME }} --password ${{ secrets.CONAN_TOKEN }}
-          echo outcome=$([ $? -eq 0 ] && echo success || echo failure) | tee ${GITHUB_OUTPUT}
+          echo outcome=$(conan user --remote ripple ${{ secrets.CONAN_USERNAME }} \
+            --password ${{ secrets.CONAN_TOKEN }} >&2 && echo success || \
+            echo failure) | tee ${GITHUB_OUTPUT}
       - name: list missing binaries
         id: binaries
         shell: bash
@@ -91,12 +91,11 @@ jobs:
           configuration: ${{ matrix.configuration }}
           # Hard code for now. Move to the matrix if varied options are needed
           cmake-args: '-Dassert=ON -Dreporting=OFF -Dunity=OFF'
-      - name: test
+      - name: test (permitted to silently fail)
         shell: bash
         # Github runners are resource limited, which causes unit tests to fail
         # (e.g. OOM). To allow forward progress until self-hosted runners are
         # up and running reliably, allow the job to succeed even if tests fail.
         continue-on-error: true
         run: |
-          # Remove these echo statements before merging
           ${build_dir}/${{ matrix.configuration }}/rippled --unittest --unittest-jobs $(nproc)