Don't pass empty library paths, classpath, java opts etc.

This clarifies the default order of the different ways to set the configs. In particular, we no longer set an empty -Djava.library.path if no library paths are given.
xiliu82 · Aug 19, 2014 · d0f20db · d0f20db
1 parent a78cb26
commit d0f20db
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 9 deletions.
diff --git a/conf/spark-defaults.conf.template b/conf/spark-defaults.conf.template
@@ -6,4 +6,5 @@
 # spark.eventLog.enabled           true
 # spark.eventLog.dir               hdfs://namenode:8021/directory
 # spark.serializer                 org.apache.spark.serializer.KryoSerializer
+# spark.driver.memory              5g
 # spark.executor.extraJavaOptions  -XX:+PrintGCDetail -Dkey=value -Dnumbers="one two three"
diff --git a/core/src/main/scala/org/apache/spark/deploy/SparkSubmitDriverBootstrapper.scala b/core/src/main/scala/org/apache/spark/deploy/SparkSubmitDriverBootstrapper.scala
@@ -58,39 +58,45 @@ private[spark] object SparkSubmitDriverBootstrapper {
     assume(defaultDriverMemory != null, "OUR_JAVA_MEM must be set")
     assume(deployMode == "client", "SPARK_SUBMIT_DEPLOY_MODE must be \"client\"!")
     assume(propertiesFile != null, "SPARK_SUBMIT_PROPERTIES_FILE must be set")
-    assume(bootstrapDriver != null, "SPARK_SUBMIT_BOOTSTRAP_DRIVER must be set!")
+    assume(bootstrapDriver != null, "SPARK_SUBMIT_BOOTSTRAP_DRIVER must be set")
 
     // Parse the properties file for the equivalent spark.driver.* configs
     val properties = SparkSubmitArguments.getPropertiesFromFile(new File(propertiesFile)).toMap
-    val confDriverMemory = properties.get("spark.driver.memory").getOrElse(defaultDriverMemory)
-    val confLibraryPath = properties.get("spark.driver.extraLibraryPath").getOrElse("")
-    val confClasspath = properties.get("spark.driver.extraClassPath").getOrElse("")
-    val confJavaOpts = properties.get("spark.driver.extraJavaOptions").getOrElse("")
+    val confDriverMemory = properties.get("spark.driver.memory")
+    val confLibraryPath = properties.get("spark.driver.extraLibraryPath")
+    val confClasspath = properties.get("spark.driver.extraClassPath")
+    val confJavaOpts = properties.get("spark.driver.extraJavaOptions")
 
     // Favor Spark submit arguments over the equivalent configs in the properties file.
     // Note that we do not actually use the Spark submit values for library path, classpath,
     // and Java opts here, because we have already captured them in Bash.
-    val newDriverMemory = submitDriverMemory.getOrElse(confDriverMemory)
+
+    val newDriverMemory = submitDriverMemory
+      .orElse(confDriverMemory)
+      .getOrElse(defaultDriverMemory)
+
     val newLibraryPath =
       if (submitLibraryPath.isDefined) {
         // SPARK_SUBMIT_LIBRARY_PATH is already captured in JAVA_OPTS
         ""
       } else {
-        "-Djava.library.path=" + confLibraryPath
+        confLibraryPath.map("-Djava.library.path=" + _).getOrElse("")
       }
+
     val newClasspath =
       if (submitClasspath.isDefined) {
         // SPARK_SUBMIT_CLASSPATH is already captured in CLASSPATH
         classpath
       } else {
-        classpath + sys.props("path.separator") + confClasspath
+        classpath + confClasspath.map(sys.props("path.separator") + _).getOrElse("")
       }
+
     val newJavaOpts =
       if (submitJavaOpts.isDefined) {
         // SPARK_SUBMIT_OPTS is already captured in JAVA_OPTS
         javaOpts
       } else {
-        javaOpts + " " + confJavaOpts
+        javaOpts + confJavaOpts.map(" " + _).getOrElse("")
       }
 
     // Build up command