Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Callback URL only uses http #23

Open
bobber205 opened this issue Apr 21, 2020 · 2 comments
Open

Callback URL only uses http #23

bobber205 opened this issue Apr 21, 2020 · 2 comments

Comments

@bobber205
Copy link

Not 100% sure this is a issue specific to this project exactly but I am opening a PR to reference to if I submit a change to the README.md file.

/**
 * Starts Twitter sign-in process for adding a user subscription
 **/
app.get('/subscriptions/add', passport.authenticate('twitter', {
  callbackURL: '/callbacks/addsub'
}));

/**
 * Starts Twitter sign-in process for removing a user subscription
 **/
app.get('/subscriptions/remove', passport.authenticate('twitter', {
  callbackURL: '/callbacks/removesub'
}));

I deployed a forked unchanged version of this project pretty easily to heroku.
For argument's sake the url is https://webhook-manager.herokuapp.com

For some reason the callback url submitted in the code above doesn't specify https. So you have to add http://webhook-manager.herokuapp.com/callbacks/addsub (http) to your callback url set for everything to work (same with /removesub)

I'm happy to add this to the README.md unless I am missing something?

@andypiper
Copy link
Collaborator

Hey, @bobber205 - long time no chat!

Thanks for this - I think I have this covered in my local version, which I'm long overdue for pushing back to GH. I believe this is correct, you should add both the http and https URLs at the moment.

If I can, I'll try to get my local changes committed over the next week. Moving this up my list for attention.

@bobber205
Copy link
Author

@andypiper Good afternoon Andy.
I'm back to working regularly on the Twitter DM platform and this tool as usual proves invaluable.

Hope things are well with you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants