Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

When editing the cxml, the live preview can display an "error parsing" parsing... #36

Open
nicolaserny opened this issue Jun 22, 2017 · 5 comments
Labels

Comments

@nicolaserny
Copy link

When I edit my cxml file, the xml will often be invalid (because I am typing).
In a live preview mode, it will be better to update the viewer only when the xml is valid.
=> better user experience
Details of the bug
http://recordit.co/QHzt18IUkA

@mbarekh
Copy link
Collaborator

mbarekh commented Jun 23, 2017

Why not update the viewer only when the user saves the cxml document ? Also, it is a more optimized approach because we are not executing the parsing in every change.

@nicolaserny
Copy link
Author

nicolaserny commented Jun 23, 2017

Why not. @maurelio1234 @Julien-Molina what do you think ?
2 solutions:

  • live update
  • update on save only

@fredericcarre
Copy link
Contributor

Another option is to have a settings in vscode:

  • live update or save only

@maurelio1234
Copy link
Member

I would do like IDE's do, when the XML becomes invalid add some kind of sign saying that it is invalid (like a red badge on the top) , but DO NOT hide the previously rendered view.

What do you think?

Side note: I prefer avoiding settings as much as possible, they hard to discover.
What do you mean by "live update"?

@nicolaserny
Copy link
Author

I think it's a good compromise and easy to use
+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants