Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a large number of failing tests might exceed the size limit #3

Closed
keewis opened this issue Nov 4, 2022 · 0 comments · Fixed by #4
Closed

a large number of failing tests might exceed the size limit #3

keewis opened this issue Nov 4, 2022 · 0 comments · Fixed by #4

Comments

@keewis
Copy link
Contributor

keewis commented Nov 4, 2022

As described in pydata/xarray#7238: a long list of failing tests might cause the github REST API to return

{"resource":"Issue","code":"custom","field":"body","message":"body is too long (maximum is 65536 characters)"}

A quick search tells me that we can either move that list somewhere else (which is not really useful, because then we could just look at the log), or we'd need to shorten / truncate the issue body.

In order not to blindly truncate, maybe we can summarize tests? For example, if we have variants of the same test that fail with the same message, we could summarize that as

xarray/tests/test_cftimeindex_resample.py::test_resample[<56 variants>]: TypeError: Grouper.__init__() got an unexpected keyword argument 'base'

Not sure what to do if the message changes, but this kind of "compression" would not lose too much information. Of course, if all of that still doesn't help we'd have to truncate (i.e. drop errors and add something like + another 285 failing tests / ... 285 failing tests omitted)

@keewis keewis changed the title lots of failing tests cause a body is too long error from the github REST API a large number of failing tests hit the size limit of the github REST API Nov 4, 2022
@keewis keewis changed the title a large number of failing tests hit the size limit of the github REST API a large number of failing tests might exceed the size limit of the github REST API Nov 4, 2022
@keewis keewis changed the title a large number of failing tests might exceed the size limit of the github REST API a large number of failing tests might exceed the size limit Nov 4, 2022
@keewis keewis closed this as completed in #4 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant