Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

[.NET 6] remove usage of System.Json #478

Closed
jonathanpeppers opened this issue Jun 15, 2021 · 5 comments
Closed

[.NET 6] remove usage of System.Json #478

jonathanpeppers opened this issue Jun 15, 2021 · 5 comments
Assignees

Comments

@jonathanpeppers
Copy link
Member

jonathanpeppers commented Jun 15, 2021

The System.Json package will not work in .NET 6. (Note this isn't the new System.Text.Json.) System.Json is a deprecated package that they don't have a way to ship an update.

It appears we use this as a dependency of Xamarin.GooglePlayServices.SafetyNet:

@if (@Model.NuGetPackageId == "Xamarin.GooglePlayServices.SafetyNet")
{
<PackageReference Include="System.Json" Version="4.5.0" />
}

Can we remove System.Json in favor of something else? Thanks!

@akoeplinger
Copy link
Member

It'd be enough to remove the package for net6.0 and up if you don't want to change how it works on existing Xamarin.

@jpobst
Copy link
Contributor

jpobst commented Jun 15, 2021

@moljac
Copy link
Member

moljac commented Jun 16, 2021

Tried to remove it, but decided to finish updates first and make it in another PR.

System.Json.JsonObject.Parse() must be replaced with System.Text.Json.JsonDocument.Parse()

@akoeplinger
Copy link
Member

akoeplinger commented Jun 23, 2021

This was done with #480 right? Or is there still something missing?

@moljac
Copy link
Member

moljac commented Jun 24, 2021

yes. It was done with #480, but issue and PR were not linked, so this issue was not closed.

Closing it right now.

@moljac moljac closed this as completed Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants