Update tests to pass

wyze · May 4, 2016 · 6cb4bc0 · 6cb4bc0
1 parent 79dd97e
commit 6cb4bc0
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 28 deletions.
diff --git a/test/base.js b/test/base.js
@@ -16,7 +16,7 @@ test('extends files', async t => {
     'wyze/rules/style',
   ]
 
-  t.same(base.extends, expected, 'extending incorrect rules in `./base`')
+  t.deepEqual(base.extends, expected, 'extending incorrect rules in `./base`')
 })
 
 test('parser', async t => {

diff --git a/test/index.js b/test/index.js
@@ -14,5 +14,5 @@ test('extends files', async t => {
     'wyze/rules/react',
   ]
 
-  t.same(main.extends, expected, 'extending incorrect rules in `./index`')
+  t.deepEqual(main.extends, expected, 'extending incorrect rules in `./index`')
 })
diff --git a/test/rules/best-practices.js b/test/rules/best-practices.js
@@ -2,9 +2,7 @@ import { rules } from '../../rules/best-practices'
 import test from 'ava'
 
 test('no react rules', async t => {
-  for ( const rule in rules ) {
-    if ( rules.hasOwnProperty(rule) ) {
-      t.notOk(~rule.indexOf('react/'), 'found react rule in undesired file')
-    }
-  }
+  Object.keys(rules).forEach(rule => {
+    t.falsy(~rule.indexOf('react/'), 'found react rule in undesired file')
+  })
 })
diff --git a/test/rules/es6.js b/test/rules/es6.js
@@ -2,11 +2,9 @@ import { parserOptions, rules } from '../../rules/es6'
 import test from 'ava'
 
 test('no react rules', async t => {
-  for ( const rule in rules ) {
-    if ( rules.hasOwnProperty(rule) ) {
-      t.notOk(~rule.indexOf('react/'), 'found react rule in undesired file')
-    }
-  }
+  Object.keys(rules).forEach(rule => {
+    t.falsy(~rule.indexOf('react/'), 'found react rule in undesired file')
+  })
 })
 
 test('enable generator support', async t => {
@@ -16,5 +14,5 @@ test('enable generator support', async t => {
     },
   }
 
-  t.same(parserOptions, expected, 'parserOptions is not enabling generators')
+  t.deepEqual(parserOptions, expected, 'parserOptions doesnt enable generators')
 })
diff --git a/test/rules/react.js b/test/rules/react.js
@@ -2,9 +2,7 @@ import { rules } from '../../rules/react'
 import test from 'ava'
 
 test('only react rules', async t => {
-  for ( const rule in rules ) {
-    if ( rules.hasOwnProperty(rule) ) {
-      t.ok(~rule.indexOf('react/'), 'rule is not for eslint-plugin-react')
-    }
-  }
+  Object.keys(rules).forEach(rule => {
+    t.truthy(~rule.indexOf('react/'), 'rule is not for eslint-plugin-react')
+  })
 })
diff --git a/test/rules/style.js b/test/rules/style.js
@@ -2,9 +2,7 @@ import { rules } from '../../rules/style'
 import test from 'ava'
 
 test('no react rules', async t => {
-  for ( const rule in rules ) {
-    if ( rules.hasOwnProperty(rule) ) {
-      t.notOk(~rule.indexOf('react/'), 'found react rule in undesired file')
-    }
-  }
+  Object.keys(rules).forEach(rule => {
+    t.falsy(~rule.indexOf('react/'), 'found react rule in undesired file')
+  })
 })
diff --git a/test/rules/variables.js b/test/rules/variables.js
@@ -2,9 +2,7 @@ import { rules } from '../../rules/variables'
 import test from 'ava'
 
 test('no react rules', async t => {
-  for ( const rule in rules ) {
-    if ( rules.hasOwnProperty(rule) ) {
-      t.notOk(~rule.indexOf('react/'), 'found react rule in undesired file')
-    }
-  }
+  Object.keys(rules).forEach(rule => {
+    t.falsy(~rule.indexOf('react/'), 'found react rule in undesired file')
+  })
 })