Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Empty value for parameter 'pull_number': undefined #16

Open
cajwo8 opened this issue Jun 8, 2021 · 5 comments
Open

Error: Empty value for parameter 'pull_number': undefined #16

cajwo8 opened this issue Jun 8, 2021 · 5 comments

Comments

@cajwo8
Copy link

cajwo8 commented Jun 8, 2021

Whenever I merge pull requests into the master branch, the checklist fails for this error. It passes upon the initial push of the pull request, though. I wonder if this is related to probot/probot#1168? Would you be able to help me with this error?

@wyozi
Copy link
Owner

wyozi commented Jun 8, 2021

Hey. Sounds weird, is the action using just the pull_request_target (or pull_request) event?

@wyozi
Copy link
Owner

wyozi commented Jun 8, 2021

Released new version which might fix this

@cajwo8
Copy link
Author

cajwo8 commented Jun 8, 2021

We're using the pull_request event

This is from the yml file

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

@wyozi
Copy link
Owner

wyozi commented Jun 8, 2021

I'd guess it's the push event, as this action won't have much to do with e.g. direct pushes to master and the pull_request trigger should called even when a PR is updated. You could separate this action to a separate action yml with just the pull_request trigger, if there's something else relying on the push event there.

@cajwo8
Copy link
Author

cajwo8 commented Jun 8, 2021

Okay, thanks! I'll try that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants