Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails in case of non-English version of Visual studio #2049

Open
GeorgeMakarov opened this issue Dec 11, 2021 · 1 comment
Open

Comments

@GeorgeMakarov
Copy link

i'm trying to install wxPython via command pip install -U wxPython

In case if Visual studio is not English, cl.exe returns localized text and function getVisCVersion() fails because can't recognize the version of MSVC.

for example for Russian version it returns (command chcp 1251 doesn't affect to returning string):

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC>cl
Оптимизирующий компилятор Microsoft (R) C/C++ версии 19.00.24245 для x86
© Корпорация Майкрософт (Microsoft Corporation). Все права защищены.

использование: cl [ параметр... ] имя_файла... [ /link параметр_компоновки... ]

while for english version it's:

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC>cl
Microsoft (R) C/C++ Optimizing Compiler Version 19.00.24245 for x86
Copyright (C) Microsoft Corporation.  All rights reserved.

usage: cl [ option... ] filename... [ /link linkoption... ]

you gotta find another way to figure version of MSVC out

@kdschlosser
Copy link
Contributor

give this PR a try and see if it works. There is a whole different mechanism in place to detect MSVC.

#2085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants