From 86a0ddbdea79849763c94b8c729da0b33baba819 Mon Sep 17 00:00:00 2001 From: Roman Strobl Date: Fri, 11 Nov 2022 15:21:56 +0100 Subject: [PATCH] Fix #522: Maximum number of presence check attempts is off by 1 --- .../impl/service/PresenceCheckLimitService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/enrollment-server-onboarding/src/main/java/com/wultra/app/onboardingserver/impl/service/PresenceCheckLimitService.java b/enrollment-server-onboarding/src/main/java/com/wultra/app/onboardingserver/impl/service/PresenceCheckLimitService.java index 9ab5dbc43..3506c3418 100644 --- a/enrollment-server-onboarding/src/main/java/com/wultra/app/onboardingserver/impl/service/PresenceCheckLimitService.java +++ b/enrollment-server-onboarding/src/main/java/com/wultra/app/onboardingserver/impl/service/PresenceCheckLimitService.java @@ -101,7 +101,7 @@ public PresenceCheckLimitService( public void checkPresenceCheckMaxAttemptLimit(OwnerId ownerId, String processId) throws IdentityVerificationException, PresenceCheckLimitException, RemoteCommunicationException { final int otpCount = otpRepository.countByProcessIdAndType(processId, OtpType.USER_VERIFICATION); // TODO (racansky, 2022-10-20, #453) OTP verification could be turned off, logic should be based on another data - if (otpCount > identityVerificationConfig.getPresenceCheckMaxFailedAttempts()) { + if (otpCount >= identityVerificationConfig.getPresenceCheckMaxFailedAttempts()) { final IdentityVerificationEntity identityVerification = identityVerificationRepository.findFirstByActivationIdOrderByTimestampCreatedDesc(ownerId.getActivationId()) .orElseThrow(() -> new IdentityVerificationException("Identity verification was not found, " + ownerId));