Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isEnd not always true #141

Closed
Kestutis opened this issue Mar 24, 2023 · 3 comments · Fixed by #145
Closed

isEnd not always true #141

Kestutis opened this issue Mar 24, 2023 · 3 comments · Fixed by #145

Comments

@Kestutis
Copy link
Contributor

Kestutis commented Mar 24, 2023

I have cases when onScroll: async ({ isEnd, top }) => { isEnd here is false, but there is no more space to scroll.
If I use trackpad and scroll with inertia I can push through this threshold to get isEnd === true.
From debugging code I can see that end: target.scrollHeight - target.clientHeight === Math.round(top), can be off just by 1px sometimes.

is there a way to set offset somehow? So can i fetch next page on infinity scroll a little bit earlier than table reached end? Also this would fix my problems when isEnd not always true, while there is no more place to scroll.

Ideally onScroll callback can expose simulated event or at least simulated event target and allow to do calculations myself.
If this something you consider, I can create PR myself.

@matepaiva
Copy link

having the same problem here, i touch the end and it says isEnd === false :(

@giorgiveego
Copy link

Same for me

@Kestutis
Copy link
Contributor Author

Kestutis commented Apr 3, 2023

@wubostc when we can expect new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants