Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Claim Uniqueness Validation] Mobile number with/without country codes should treated as same when checking for uniqueness #23173

Open
Thumimku opened this issue Feb 20, 2025 · 1 comment

Comments

@Thumimku
Copy link
Contributor

Current Limitation

The Uniqueness Claim Validation feature existed previously, but we recently introduced significant improvements as part of this update.

Some claims can have multiple string representations that refer to the same real-world entity. For example, in the case of a mobile number, both +94771234567 and 0771234567 represent the same number. However, under the current implementation, two different users can still register these variations, even when uniqueness enforcement is enabled.

Suggested Improvement

Analyse and add claim specific unique ness validations also if possible.

Version

No response

@PasinduYeshan
Copy link
Contributor

@Thumimku
Then we’ll need to mandate country codes, right? Otherwise, we won’t know which country code to apply to the provided mobile number for normalization. Also, for existing data, we would likely need a migration process to convert all phone numbers into a consistent format—otherwise enforcing uniqueness would be quite complex. If you have any alternate ideas please mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants