Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Months support doesn't seem to work #13

Open
martinb3 opened this issue Jan 10, 2017 · 3 comments
Open

Months support doesn't seem to work #13

martinb3 opened this issue Jan 10, 2017 · 3 comments

Comments

@martinb3
Copy link

martinb3 commented Jan 10, 2017

Hello! Based on #7 and the PR #10 from @duramato, I expected to be able to use an expression like "1 month" using the current HEAD, but that doesn't seem to actually work:

$  mkvirtualenv foo
$ workon foo
$ pip install -e -e git://github.com/wroberts
$ pip install -e git://github.com/wroberts/pytimeparse.git@cc0550d3f4ec72d745ef2387603005ab52aa9538#egg=pytimeparse
Obtaining pytimeparse from git+git://github.com/wroberts/pytimeparse.git@cc0550d3f4ec72d745ef2387603005ab52aa9538#egg=pytimeparse
  Cloning git://github.com/wroberts/pytimeparse.git (to cc0550d3f4ec72d745ef2387603005ab52aa9538) to ./.virtualenvs/foo/src/pytimeparse
  Could not find a tag or branch 'cc0550d3f4ec72d745ef2387603005ab52aa9538', assuming commit.
Installing collected packages: pytimeparse
  Running setup.py develop for pytimeparse
Successfully installed pytimeparse
(foo) ➜  ~  python
Python 2.7.12 (default, Jun 29 2016, 14:05:02)
[GCC 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from pytimeparse.timeparse import timeparse
>>> timeparse("1 month")
>>> timeparse("30 days")
2592000
>>>
@duramato
Copy link
Contributor

duramato commented Jan 10, 2017

Have you uncommented the references to months in the code?

@martinb3
Copy link
Author

martinb3 commented Jan 10, 2017

@duramato -- no, apparently I didn't catch that. I wasn't expecting that. Maybe this should be in a branch so it's at least able to be pip install'd?

@duramato
Copy link
Contributor

duramato commented Jan 10, 2017

When I added it, did it commented per @wroberts "wish", since months/years are relative times to the calendar, more info #7 (comment).
To make it a branch sounds like a good idea, what you think @wroberts . Or maybe include it in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants