Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate caching_sha2_password addition on PHP < 7.4 #226

Closed
swissspidy opened this issue Oct 9, 2024 · 2 comments
Closed

Re-evaluate caching_sha2_password addition on PHP < 7.4 #226

swissspidy opened this issue Oct 9, 2024 · 2 comments

Comments

@swissspidy
Copy link
Member

swissspidy commented Oct 9, 2024

In #220, we replaced mysql_native_password with caching_sha2_password.

That seemed to work fine everywhere, but in the wp-cli-bundle repo there are some warnings:

https://github.com/wp-cli/wp-cli-bundle/actions/runs/11257982684/job/31305127211#step:15:218

Nowhere else though 🤔

Maybe we need to update the tests script to change that conditionally based on the PHP version.

@swissspidy
Copy link
Member Author

Maybe it has more to do with the setup on that repo though? Will add details at wp-cli/wp-cli-bundle#666

@swissspidy
Copy link
Member Author

Closing as I don't see any test failures anymore

@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant