Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with ModelingToolkit 9 #208

Closed
rogersamso opened this issue Apr 10, 2024 · 1 comment · Fixed by #209
Closed

Compatibility with ModelingToolkit 9 #208

rogersamso opened this issue Apr 10, 2024 · 1 comment · Fixed by #209

Comments

@rogersamso
Copy link
Contributor

Hi!

I have been playing around with the library, and noticed that adding compatibility with ModelingToolkit 9 would just require replacing:

  1. All instances of ODESystem(eqs; name) by ODESystem(eqs, t; name)
  2. Function states by function unknowns (see refactor: rename states to unknowns, and related changes SciML/ModelingToolkit.jl#2432)

And then update the Project.toml file.

If you'd like to make those changes I can do a PR.

Best
@aurorarossi
Copy link
Member

Yes, that would be really appreciated!
Thank you very much!

@rogersamso rogersamso mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add compatibility with ModelingToolkit 9 rogersamso/WorldDynamics.jl
2 participants
@rogersamso @aurorarossi