Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Placeholders in Social Icons block not visible with some block-based themes #4780

Closed
SiobhyB opened this issue Apr 21, 2022 · 0 comments · Fixed by WordPress/gutenberg#55398
Assignees
Labels

Comments

@SiobhyB
Copy link
Contributor

SiobhyB commented Apr 21, 2022

Describe the bug

When dark mode is enabled and a block-based theme with a light background colour is active, the placeholder icons shown for inactive icons are not visible in the Social Icons block.

To Reproduce

Steps to reproduce the behavior:

  1. Enable dark mode on your iOS or Android device and open the app.
  2. Activate a block-based theme with a light background colour, such as Zoologist, on a WordPress.com site.
  3. Navigate to the site's post editor and observe the light background defined by the block-based theme.
  4. Add the Social Icons block to the editor.
  5. Notice that only the default active WordPress icon is visible, the other inactive, placeholder icons are not visible.

Expected behavior

All icons in the block should be visible, with the inactive, placeholder icons in gray and the active icons in colour.

Screenshots

Expectation Actual

Smartphone (please complete the following information):

  • Device: Pixel 6
  • OS: Android 12
  • Version: 19.7-rc-1

Additional context

This is related to the fact that the editor's background colour doesn't change with dark mode when a block-based theme is active, as outlined in #4468.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (keep clean, manually)
2 participants