From c2fff355b068087a31df37ffe6042647e8a44a5d Mon Sep 17 00:00:00 2001 From: Siobhan Bamber Date: Tue, 20 Apr 2021 16:57:58 +0100 Subject: [PATCH 1/3] Update WPAndroid Integration.md Updates the WPAndroid Integration doc to include a note about waiting for tests to pass in gutenberg-mobile. --- WPAndroid Integration.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/WPAndroid Integration.md b/WPAndroid Integration.md index c4e3edd9dd..8f8913d8e4 100644 --- a/WPAndroid Integration.md +++ b/WPAndroid Integration.md @@ -12,6 +12,8 @@ To do this, we need to copy the [local-builds.gradle-example file](https://githu Building the project as such will make WPAndroid build the source code for `react-native-bridge`, `react-native-aztec` and other sublibraries from the locally checked out folder. It'll also expect the metro server to be running to fetch the JS bundle. +**Note:** The `ci/circleci: Build Android RN Bridge & Publish to Bintray` task in `gutenberg-mobile` needs to complete before WPAndroid's `Installable Build` CI task will succeed. As such, you may see WPAndroid's CI tasks fail with a 403 error if they run before the `gutenberg-mobile` task completes. Before deploying any changes to `ext.gutenbergMobileVersion`, either wait for the tests to pass in `gutenberg-mobile` first or restart the WPAndroid CI tasks after they pass. + - [Work with local gutenberg-mobile checkout](#work-with-local-gutenberg-mobile-checkout) - [Deploy a new version of `react-native-bridge` from CI](#deploy-a-new-version-of-react-native-bridge-from-ci) - [Manually deploy a new version of `react-native-bridge`](#manually-deploy-a-new-version-of-react-native-bridge) From bfa46956ff9b220cc6949af1f1321745a1dc3c86 Mon Sep 17 00:00:00 2001 From: Siobhan Bamber Date: Tue, 20 Apr 2021 17:23:28 +0100 Subject: [PATCH 2/3] Tweaks to wording Co-authored-by: David Calhoun --- WPAndroid Integration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WPAndroid Integration.md b/WPAndroid Integration.md index 8f8913d8e4..17d8de0643 100644 --- a/WPAndroid Integration.md +++ b/WPAndroid Integration.md @@ -12,7 +12,7 @@ To do this, we need to copy the [local-builds.gradle-example file](https://githu Building the project as such will make WPAndroid build the source code for `react-native-bridge`, `react-native-aztec` and other sublibraries from the locally checked out folder. It'll also expect the metro server to be running to fetch the JS bundle. -**Note:** The `ci/circleci: Build Android RN Bridge & Publish to Bintray` task in `gutenberg-mobile` needs to complete before WPAndroid's `Installable Build` CI task will succeed. As such, you may see WPAndroid's CI tasks fail with a 403 error if they run before the `gutenberg-mobile` task completes. Before deploying any changes to `ext.gutenbergMobileVersion`, either wait for the tests to pass in `gutenberg-mobile` first or restart the WPAndroid CI tasks after they pass. +**Note:** The `Build Android RN Bridge & Publish to Bintray` task in `gutenberg-mobile` needs to complete before WPAndroid's `Installable Build` CI task will succeed. As such, you may see WPAndroid's CI tasks fail with a 403 error if they run before the `gutenberg-mobile` task completes. You can either wait for wait for `gutenberg-mobile`'s CI task to pass before pushing changes to `ext.gutenbergMobileVersion` or restart failed WPAndroid CI tasks after `gutenberg-mobile`'s CI task passes. - [Work with local gutenberg-mobile checkout](#work-with-local-gutenberg-mobile-checkout) - [Deploy a new version of `react-native-bridge` from CI](#deploy-a-new-version-of-react-native-bridge-from-ci) From 0b00b3492d3bfbf4bebaa8f9e254f236ab31ad5a Mon Sep 17 00:00:00 2001 From: Siobhan Bamber Date: Tue, 20 Apr 2021 17:26:36 +0100 Subject: [PATCH 3/3] Change positioning of note for clarification --- WPAndroid Integration.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/WPAndroid Integration.md b/WPAndroid Integration.md index 17d8de0643..4f6785a541 100644 --- a/WPAndroid Integration.md +++ b/WPAndroid Integration.md @@ -12,8 +12,6 @@ To do this, we need to copy the [local-builds.gradle-example file](https://githu Building the project as such will make WPAndroid build the source code for `react-native-bridge`, `react-native-aztec` and other sublibraries from the locally checked out folder. It'll also expect the metro server to be running to fetch the JS bundle. -**Note:** The `Build Android RN Bridge & Publish to Bintray` task in `gutenberg-mobile` needs to complete before WPAndroid's `Installable Build` CI task will succeed. As such, you may see WPAndroid's CI tasks fail with a 403 error if they run before the `gutenberg-mobile` task completes. You can either wait for wait for `gutenberg-mobile`'s CI task to pass before pushing changes to `ext.gutenbergMobileVersion` or restart failed WPAndroid CI tasks after `gutenberg-mobile`'s CI task passes. - - [Work with local gutenberg-mobile checkout](#work-with-local-gutenberg-mobile-checkout) - [Deploy a new version of `react-native-bridge` from CI](#deploy-a-new-version-of-react-native-bridge-from-ci) - [Manually deploy a new version of `react-native-bridge`](#manually-deploy-a-new-version-of-react-native-bridge) @@ -90,6 +88,8 @@ Besides checking a few things, `publish-aztec-and-bridge.sh` script will clean t In order to test this, make sure `localGutenbergMobilePath` in your `local-builds.gradle` file is commented out as otherwise the binary version will be ignored. +**Note:** The `Build Android RN Bridge & Publish to Bintray` task in `gutenberg-mobile` needs to complete before WPAndroid's `Installable Build` CI task will succeed. As such, you may see WPAndroid's CI tasks fail with a 403 error if they run before the `gutenberg-mobile` task completes. You can either wait for wait for `gutenberg-mobile`'s CI task to pass before pushing changes to `ext.gutenbergMobileVersion` or restart failed WPAndroid CI tasks after `gutenberg-mobile`'s CI task passes. + --- ## How to