Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade micromark deps? #76

Closed
4 tasks done
kentcdodds opened this issue Aug 11, 2021 · 4 comments
Closed
4 tasks done

Upgrade micromark deps? #76

kentcdodds opened this issue Aug 11, 2021 · 4 comments

Comments

@kentcdodds
Copy link

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions: 1.12.2

Steps to reproduce

I'm struggling to figure out how to reproduce this issue 😬 I'm experiencing it in https://github.com/kentcdodds/remix-kentcdodds but you'd need a remix license to run that 😅

Expected behavior

I expect to be able to use the latest version of all packages together without trouble.

Actual behavior

Basically, when I use the latest version of remark-gfm with the latest version of xdm, I run into the issue mentioned here: #75 and I'm pretty sure it has to do with the fact that xdm is still using (transitively) an old version of remark-parser and micromark:

npm ls micromark
kentcdodds.com@1.0.0 /Users/kentcdodds/code/remix-kentcdodds
├─┬ mdx-bundler@5.2.1
│ └─┬ xdm@1.12.2
│   ├─┬ micromark-extension-mdxjs@0.3.0
│   │ ├─┬ micromark-extension-mdx-expression@0.3.2
│   │ │ └── micromark@2.11.4
│   │ ├─┬ micromark-extension-mdx-jsx@0.3.3
│   │ │ └── micromark@2.11.4
│   │ ├─┬ micromark-extension-mdxjs-esm@0.3.1
│   │ │ └── micromark@2.11.4
│   │ └── micromark@2.11.4
│   └─┬ remark-parse@9.0.0
│     └─┬ mdast-util-from-markdown@0.8.5
│       └── micromark@2.11.4
└─┬ remark-parse@10.0.0
  └─┬ mdast-util-from-markdown@1.0.0
    └── micromark@3.0.3

The only workaround I've found so far is to downgrade remark-gfm to 1.0.0.

@ChristianMurphy
Copy link
Collaborator

ChristianMurphy commented Aug 11, 2021

Heya @kentcdodds 👋 sorry you ran into a spot of trouble.
This is related to unified rolling out new majors of most plugins unifiedjs/unified#121
These updates are currently making their way through remark-* packages. (for example react-markdown is also in a similar spot temporarily waiting for updates remarkjs/react-markdown#626 remarkjs/react-markdown#629)
Soon after remark-* packages are updated, xdm can be updated.

A fix is incoming 🚀 as a temporary workaround hold remark-* plugins one major release back from latest.

@wooorm
Copy link
Owner

wooorm commented Aug 11, 2021

I’m halve way with remark-lint. Which I can probably finish today. So expect xdm/react-markdown end-of-day or tomorrow!

@wooorm wooorm closed this as completed in a33caec Aug 12, 2021
@wooorm
Copy link
Owner

wooorm commented Aug 12, 2021

done!

@kentcdodds
Copy link
Author

Sweet! Thank you so much. It feels so good to be able to be on the latest version of every one of my deps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants