Fix subsyntaxes if their language cannot be inferred

Closes GH-17. Closes GH-18. Reviewed-by: Takayuki Shimada <taka@tsmd.jp> Co-authored-by: Takayuki Shimada <taka@tsmd.jp>
wooorm · May 20, 2019 · fda353b · fda353b
1 parent 51b3d4a
commit fda353b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/lib/core.js b/lib/core.js
@@ -362,6 +362,12 @@ function coreHighlight(name, value, ignore, prefix, continuation) {
       })
     }
 
+    // If we couldn’t highlight, for example because the requests subset isn’t
+    // loaded, return a text node.
+    if (!subvalue.language) {
+      return [buildText(modeBuffer)]
+    }
+
     // Counting embedded language score towards the host language may be
     // disabled with zeroing the containing mode relevance.
     // Usecase in point is Markdown that allows XML everywhere and makes every

diff --git a/test/fixture/xml-sublanguages-2/input.txt b/test/fixture/xml-sublanguages-2/input.txt
@@ -0,0 +1 @@
+<script>foo()</script>
diff --git a/test/fixture/xml-sublanguages-2/output.txt b/test/fixture/xml-sublanguages-2/output.txt
@@ -0,0 +1 @@
+<span class="hljs-tag">&#x3C;<span class="hljs-name">script</span>></span>foo()<span class="hljs-tag">&#x3C;/<span class="hljs-name">script</span>></span>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		<span class="hljs-tag"><<span class="hljs-name">script</span>></span>foo()<span class="hljs-tag"></<span class="hljs-name">script</span>></span>