Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up Dockerfiles and remove dependency on drone/ca-certs #288

Closed
UnlimitedCookies opened this issue Aug 30, 2021 · 4 comments · Fixed by #398
Closed

Tidy up Dockerfiles and remove dependency on drone/ca-certs #288

UnlimitedCookies opened this issue Aug 30, 2021 · 4 comments · Fixed by #398
Labels
build CI pipeline related
Milestone

Comments

@UnlimitedCookies
Copy link
Contributor

UnlimitedCookies commented Aug 30, 2021

I would love to test out the UI rewrite, but I am confused by the seemingly duplicate Dockerfiles.

E. g. Dockerfile.agent{.alpine} seem quite similar.

The Dockerfile.agent apparently still depends on drone/ca-certs, which I think should be dropped.

@anbraten
Copy link
Member

I already started on doing that in #257

To test the UI rewrite ATM the easiest way is currently to checkout that branch and run woodpecker via the debug with vs-code.

@UnlimitedCookies
Copy link
Contributor Author

Awesome, that PR already looks promising.

I am still wondering though why there are still two very similar docker images (one ending with .alpine).

@anbraten
Copy link
Member

Without alpine is the scratch image with just the binaries in it and with .alpine is an image based on alpine so you are able to use a command line. I prefer the scratch images, but some others like to have a command line next to woodpecker so we have both.

@UnlimitedCookies
Copy link
Contributor Author

I understand, thanks for the explanation!

Even better would it be to just let docker handle the building with a docker-compose.yml. Is that currently possible?

@6543 6543 added the build CI pipeline related label Sep 21, 2021
@anbraten anbraten added this to the 0.15.0 milestone Sep 23, 2021
@6543 6543 closed this as completed in #398 Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI pipeline related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants