Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Split PE] Implement Split PE for cards in the block checkout #2789

Closed
a-danae opened this issue Nov 27, 2023 · 1 comment
Closed

[Split PE] Implement Split PE for cards in the block checkout #2789

a-danae opened this issue Nov 27, 2023 · 1 comment
Assignees

Comments

@a-danae
Copy link
Contributor

a-danae commented Nov 27, 2023

Acceptance criteria

  • When multiple payment method types are enabled, they must appear as different payment gateways in the classic checkout, as it happens when PE is disabled. Design xVAk98kbRKUByVTrhPc98g-fi-342_8806
  • Payment processing must continue to work for cards
  • Changes must be covered by tests
  • e2e tests must be adjusted to at least maintain the same coverage they had before split PE

Notes

This might be handled in #2784. Confirm before grabbing this issue.

@a-danae a-danae added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Nov 27, 2023
@a-danae a-danae removed the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Dec 17, 2023
@james-allan james-allan self-assigned this Jan 3, 2024
@james-allan
Copy link
Contributor

This has been handled in #2784.

On the latest add/deferred-intent working branch, Cards with split have been implemented exclusively.

Screenshot 2024-01-04 at 9.56.07 am.png

No other alternative payment method has been implemented yet.

The way I implemented it for #2784, it loops over all the payment methods IDs (ref) and attempts to register the Payment method with the Blocks API (ref).

The reason this doesn't work to implement split for all APMs is because those payment methods haven't been registered via the $payment_method_registry (see this guide) and so it doesn't load. That's the next step as part of #2790.

Given cards have already been implemented with Split UPE and they work to take card payments I'm going to close this as fixed in #2784.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants