Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deferred intent] Card - Implement saving cards in the checkout and using saved ones #2760

Closed
a-danae opened this issue Nov 17, 2023 · 1 comment
Assignees

Comments

@a-danae
Copy link
Contributor

a-danae commented Nov 17, 2023

Acceptance criteria

  • The behavior for users must continue to be the same as with the legacy PE implementation
  • Allowing saving cards and used saved ones must continue to follow the "Enable payments via saved cards" setting
  • Checking off the "save card" checkbox does save the card in:
    • The block checkout
    • The shortcode checkout
    • The Pay for order page
  • Saved cards show up on:
    • The block checkout
    • The shortcode checkout
    • The Pay for order page
    • The My account -> Payment methods page
  • When using a saved payment method, its related billing address must be updated with the billing address specified in the order
  • Deleting a saved card under the My account -> Payment methods page removes the card from the WC store and from the Stripe customer. We likely don't need changes here, but let's confirm it
  • Errors must be handled gracefully:
    • A relevant, user-friendly message must be shown to shoppers
    • A relevant note must be added to the order
    • A detailed message of the error must be logged to the log files if enabled
    • The order status must reflect the payment status
  • The following critical flows and e2e tests must behave as expected (use the legacy PE implementation as a reference if in doubt):

Out of scope

  • Adding new cards under the My account -> Payment methods page
  • Adding 3DS cards
@a-danae a-danae added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Nov 19, 2023
@a-danae a-danae added status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. and removed status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. labels Nov 27, 2023
@a-danae a-danae self-assigned this Nov 28, 2023
@a-danae
Copy link
Contributor Author

a-danae commented Feb 12, 2024

This is working as expected. The e2e tests won't fail at this point because the legacy code hasn't been removed. Let's tackle those separately to include other flows too.

@a-danae a-danae closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant